Re: [TopGit PATCH] tg.sh: Check for read permissions of help files

From: Petr Baudis <pasky@suse.cz>
Date: Aug 9, 2008, 08:24 UTC
Message-ID: <20080809082436.GU10151@machine.or.cz>
In-Reply-To: <36ca99e90808090035r6331a118k5a26486de1acf002@mail.gmail.com>

On Sat, Aug 09, 2008 at 09:35:19AM +0200, Bert Wesarg wrote:

Show 8 quoted lines

> Petr,
> 
> On Wed, Aug 6, 2008 at 10:02, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> > -       elif [ -f "@sharedir@/tg-$1.txt" ] ; then
> > +       elif [ -f "@sharedir@/tg-$1.txt" -a -r "@sharedir@/tg-$1.txt" ] ; then
> I saw your simplified commit for this, but you should know, that '-r'
> tests only for read permissions, not for a regular file, so this test
> succeed also for a pipe/socket for which do you have read permissions.

Is that a problem? :-)

				Petr "Pasky" Baudis