[PATCH JGIT] Equals method should not assume anything about the type of its argument
The equals(Object o) method shouldn't make any assumptions about the type of o. It should simply return false if o is not the same type as this.
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
---
.../src/org/spearce/jgit/lib/AnyObjectId.java | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
index 2e3a43e..0bd2288 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
@@ -253,7 +253,11 @@ public boolean equals(final AnyObjectId other) {
}
public boolean equals(final Object o) {
- return equals((AnyObjectId) o);
+ if (o instanceof AnyObjectId) {
+ return equals((AnyObjectId) o);
+ } else {
+ return false;
+ }
}
/**
--
1.6.2.2.1669.g7eaf8
Sohn, Matthias <matthias.sohn@sap.com>