From: Sohn, Matthias Date: Wed, 29 Apr 2009 14:54:44 GMT Subject: [PATCH JGIT] Equals method should not assume anything about the type of its argument Message-ID: <366BBB1215D0AB4B8A153AF047A287800302A6F9@dewdfe18.wdf.sap.corp> The equals(Object o) method shouldn't make any assumptions about the type of o. It should simply return false if o is not the same type as this. Signed-off-by: Matthias Sohn --- .../src/org/spearce/jgit/lib/AnyObjectId.java | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java index 2e3a43e..0bd2288 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java @@ -253,7 +253,11 @@ public boolean equals(final AnyObjectId other) { } public boolean equals(final Object o) { - return equals((AnyObjectId) o); + if (o instanceof AnyObjectId) { + return equals((AnyObjectId) o); + } else { + return false; + } } /** -- 1.6.2.2.1669.g7eaf8