Re: [PATCH v2] doc: imply that interactive.singleKey is disabled by default
- From
- Dragan Simic <dsimic@manjaro.org>
- Date
- May 31, 2024, 00:49 UTC
- Message-ID
- <35f5633ebf263ec743d673770eb86487@manjaro.org>
- In-Reply-To
- <673887a14c4f74deb4ef7771a331689b@manjaro.org>
On 2024-05-22 23:34, Dragan Simic wrote:
Show 37 quoted lines
> On 2024-05-22 23:31, Junio C Hamano wrote: >> Dragan Simic <dsimic@manjaro.org> writes: >> >>> 1: 3141fe9f7328 ! 1: 7da73f15a018 doc: note that >>> interactive.singleKey is disabled by default >>> @@ Metadata >>> Author: Dragan Simic <dsimic@manjaro.org> >>> >>> ## Commit message ## >>> - doc: note that interactive.singleKey is disabled by default >>> + doc: imply that interactive.singleKey is disabled by default >>> >>> Make it clear that the interactive.singleKey configuration >>> option is disabled >> >> Heh, "note that" would probably be better, as we are going to say >> "Make it clear" anyway, no? That is stronger than just to imply. >> >> Keeping the original version of the log message probably was >> sufficient. > > Yeah, but I felt like it needed some adjustments, because the patch > itself was actually changed. I hope I won't have to send the v3 > because of that? :) > >>> + When set to true, allow the user to provide one-letter input >>> + with a single key (i.e., without hitting the Enter key) in >>> + interactive commands. This is currently used by the `--patch` >>> + mode of linkgit:git-add[1], linkgit:git-checkout[1], >>> linkgit:git-restore[1], linkgit:git-commit[1], >>> linkgit:git-reset[1], and linkgit:git-stash[1]. >>> >> >> The resulting text reads well. >> Nicely done. > > Thanks.
Just checking, is there something left to be addressed for this patch, before it can be considered to be pulled into the next branch?