git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/14] get_parent(): defensive programming

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 15, 2025, 12:45 UTC
Message-ID
<35c4870e2c101c9ef72d1657c8f6dd077cecc5fa.1747313140.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1890.git.1747313139.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

CodeQL points out that `lookup_commit_reference()` can return NULL values.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 object-name.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/object-name.c b/object-name.c
index 76749fbfe652..ca54dad2f4c8 100644
--- a/object-name.c
+++ b/object-name.c
@@ -1106,7 +1106,7 @@ static enum get_oid_result get_parent(struct repository *r,
 	if (ret)
 		return ret;
 	commit = lookup_commit_reference(r, &oid);
-	if (repo_parse_commit(r, commit))
+	if (!commit || repo_parse_commit(r, commit))
 		return MISSING_OBJECT;
 	if (!idx) {
 		oidcpy(result, &commit->object.oid);
-- 
gitgitgadget
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 19 in “Some defensive programming”
  1. 00/14 Some defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  2. 01/14 revision: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  3. Junio C HamanoMay 15, 2025
  4. 02/14 get_parent(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  5. Junio C HamanoMay 15, 2025
  6. Jeff KingMay 15, 2025
  7. 03/14 fetch-pack: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  8. Junio C HamanoMay 15, 2025
  9. 04/14 unparse_commit(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  10. 05/14 verify_commit_graph(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  11. 06/14 stash: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  12. 07/14 stash: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  13. 08/14 push: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  14. 09/14 fetch: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  15. 10/14 describe: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  16. 11/14 inherit_tracking(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  17. 12/14 submodule: check return value of `submodule_from_path()`Johannes Schindelin via GitGitGadget, May 15, 2025
  18. 13/14 test-tool repository: check return value of `lookup_commit()`Johannes Schindelin via GitGitGadget, May 15, 2025
  19. 14/14 shallow: handle missing shallow commits gracefullyJohannes Schindelin via GitGitGadget, May 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.