[PATCH 02/14] get_parent(): defensive programming
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- May 15, 2025, 12:45 UTC
- Message-ID
- <35c4870e2c101c9ef72d1657c8f6dd077cecc5fa.1747313140.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1890.git.1747313139.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
CodeQL points out that `lookup_commit_reference()` can return NULL values.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- object-name.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/object-name.c b/object-name.c index 76749fbfe652..ca54dad2f4c8 100644 --- a/object-name.c +++ b/object-name.c @@ -1106,7 +1106,7 @@ static enum get_oid_result get_parent(struct repository *r, if (ret) return ret; commit = lookup_commit_reference(r, &oid); - if (repo_parse_commit(r, commit)) + if (!commit || repo_parse_commit(r, commit)) return MISSING_OBJECT; if (!idx) { oidcpy(result, &commit->object.oid);
-- gitgitgadget