git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 13/14] test-tool repository: check return value of `lookup_commit()`

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 15, 2025, 12:45 UTC
Message-ID
<137f6c45af74c718e7acf0e3a569633291dcbc43.1747313140.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1890.git.1747313139.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
On the off-chance that it's NULL...
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/helper/test-repository.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/t/helper/test-repository.c b/t/helper/test-repository.c
index 63c37de33d22..05417d8f43dc 100644
--- a/t/helper/test-repository.c
+++ b/t/helper/test-repository.c
@@ -27,6 +27,8 @@ static void test_parse_commit_in_graph(const char *gitdir, const char *worktree,
 	repo_set_hash_algo(the_repository, hash_algo_by_ptr(r.hash_algo));
 
 	c = lookup_commit(&r, commit_oid);
+	if (!c)
+		die("Could not look up %s", oid_to_hex(commit_oid));
 
 	if (!parse_commit_in_graph(&r, c))
 		die("Couldn't parse commit");
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 18 of 19 in “Some defensive programming”
  1. 00/14 Some defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  2. 01/14 revision: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  3. Junio C HamanoMay 15, 2025
  4. 02/14 get_parent(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  5. Junio C HamanoMay 15, 2025
  6. Jeff KingMay 15, 2025
  7. 03/14 fetch-pack: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  8. Junio C HamanoMay 15, 2025
  9. 04/14 unparse_commit(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  10. 05/14 verify_commit_graph(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  11. 06/14 stash: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  12. 07/14 stash: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  13. 08/14 push: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  14. 09/14 fetch: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  15. 10/14 describe: defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  16. 11/14 inherit_tracking(): defensive programmingJohannes Schindelin via GitGitGadget, May 15, 2025
  17. 12/14 submodule: check return value of `submodule_from_path()`Johannes Schindelin via GitGitGadget, May 15, 2025
  18. 13/14 test-tool repository: check return value of `lookup_commit()`Johannes Schindelin via GitGitGadget, May 15, 2025
  19. 14/14 shallow: handle missing shallow commits gracefullyJohannes Schindelin via GitGitGadget, May 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.