Re: [PATCH 5/5] completion: drop "stash save" completion altogether

> Le 16 oct. 2026 à 04:01, Patrick Steinhardt <ps@pks.im> a écrit :
> 
> On Mon, Oct 12, 2026 at 01:48:31PM -0400, D. Ben Knoble wrote:
>> It's been deprecated since fd2ebf14db (stash: mark "git stash save"
>> deprecated in the man page, 2017-10-22) and the previous commit removed
>> further documentation suggesting to use it.
>> 
>> Since we recommend push instead, stop completing for "save" and remove a
>> special case in completion code.
> 
> This is the only part I'm a bit torn on. I think it's reasonable to not
> autocomplete the "save" command, but if the user manually types it,
> should we really stop autocompleting its options altogether?
> 
> Maybe the answer is "yes". After all, as you mentioned in the preceding
> commit, the command is deprecated since 2017 already! And after almost
> 10 years I think it's fair to start giving users more nudges into the
> direction of using "push" instead.
> 
> One note though: the command _will_ be completed in the case where you
> have GIT_COMPLETION_SHOW_ALL set