Re: [PATCH] gitweb: Show project's README.html if available
- From
- Luben Tuikov <ltuikov@yahoo.com>
- Date
- Oct 24, 2006, 08:43 UTC
- Message-ID
- <350280.74860.qm@web31804.mail.mud.yahoo.com>
- In-Reply-To
- <20061024032346.4185.85330.stgit@rover>
--- Petr Baudis <pasky@suse.cz> wrote:
Show 14 quoted lines
> If the repository includes a README.html file, show it in the summary page. > The usual "this should be in the config file" argument does not apply here > since this can be larger and having such a big string in the config file > would be impractical. > > I don't know if this is suitable upstream, but it's one of the repo.or.cz > custom modifications that I've thought could be interesting for others > as well. > > Compared to the previous patch, this adds the '.html' extension to the > filename, so that it's clear it is, well, HTML. > > Signed-off-by: Petr Baudis <pasky@suse.cz> > ---
Why not instead re-submit a patch implementing what was discussed in this thread bearing the same name:
http://marc.theaimsgroup.com/?t=116044914900001&r=1&w=2
Luben
Show 28 quoted lines
>
> gitweb/gitweb.perl | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 3b26ec3..81adc71 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2538,6 +2538,14 @@ sub git_summary {
> }
> print "</table>\n";
>
> + if (-s "$projectroot/$project/README.html") {
> + if (open my $fd, "$projectroot/$project/README.html") {
> + print "<div class=\"title\">readme</div>\n";
> + print $_ while (<$fd>);
> + close $fd;
> + }
> + }
> +
> open my $fd, "-|", git_cmd(), "rev-list", "--max-count=17",
> git_get_head_hash($project)
> or die_error(undef, "Open git-rev-list failed");
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>