git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Show project's README.html if available

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Oct 24, 2006, 08:43 UTC
Message-ID
<350280.74860.qm@web31804.mail.mud.yahoo.com>
In-Reply-To
<20061024032346.4185.85330.stgit@rover>
--- Petr Baudis <pasky@suse.cz> wrote:
Show 14 quoted lines
> If the repository includes a README.html file, show it in the summary page.
> The usual "this should be in the config file" argument does not apply here
> since this can be larger and having such a big string in the config file
> would be impractical.
> 
> I don't know if this is suitable upstream, but it's one of the repo.or.cz
> custom modifications that I've thought could be interesting for others
> as well.
> 
> Compared to the previous patch, this adds the '.html' extension to the
> filename, so that it's clear it is, well, HTML.
> 
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---

Why not instead re-submit a patch implementing what was discussed in this thread bearing the same name:

http://marc.theaimsgroup.com/?t=116044914900001&r=1&w=2
     Luben
Show 28 quoted lines
> 
>  gitweb/gitweb.perl |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 3b26ec3..81adc71 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2538,6 +2538,14 @@ sub git_summary {
>  	}
>  	print "</table>\n";
>  
> +	if (-s "$projectroot/$project/README.html") {
> +		if (open my $fd, "$projectroot/$project/README.html") {
> +			print "<div class=\"title\">readme</div>\n";
> +			print $_ while (<$fd>);
> +			close $fd;
> +		}
> +	}
> +
>  	open my $fd, "-|", git_cmd(), "rev-list", "--max-count=17",
>  		git_get_head_hash($project)
>  		or die_error(undef, "Open git-rev-list failed");
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Previous: Petr BaudisNext: Petr Baudis
Message 2 of 3 in “gitweb: Show project's README.html if available”
  1. gitweb: Show project's README.html if availablePetr Baudis, Oct 24, 2006
  2. Luben TuikovOct 24, 2006
  3. Petr BaudisOct 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.