threads / patch / 6028

patchgitweb: Show project's README.html if available

Subject: [PATCH] gitweb: Show project's README.html if available

## tl;dr

3 messages between Oct 24, 2006 and Oct 24, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Petr Baudis· Oct 24, 2006, 03:23 UTC · lore

If the repository includes a README.html file, show it in the summary page. The usual "this should be in the config file" argument does not apply here since this can be larger and having such a big string in the config file would be impractical.

I don't know if this is suitable upstream, but it's one of the repo.or.cz custom modifications that I've thought could be interesting for others as well.

Compared to the previous patch, this adds the '.html' extension to the filename, so that it's clear it is, well, HTML.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---
 gitweb/gitweb.perl |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Show changes to gitweb/gitweb.perl +8 −0
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 3b26ec3..81adc71 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2538,6 +2538,14 @@ sub git_summary {
 	}
 	print "</table>\n";
 
+	if (-s "$projectroot/$project/README.html") {
+		if (open my $fd, "$projectroot/$project/README.html") {
+			print "<div class=\"title\">readme</div>\n";
+			print $_ while (<$fd>);
+			close $fd;
+		}
+	}
+
 	open my $fd, "-|", git_cmd(), "rev-list", "--max-count=17",
 		git_get_head_hash($project)
 		or die_error(undef, "Open git-rev-list failed");
Luben Tuikov· Oct 24, 2006, 08:43 UTC · re: Petr Baudis · lore

Re: [PATCH] gitweb: Show project's README.html if available

--- Petr Baudis <pasky@suse.cz> wrote:
Show 14 quoted lines
> If the repository includes a README.html file, show it in the summary page.
> The usual "this should be in the config file" argument does not apply here
> since this can be larger and having such a big string in the config file
> would be impractical.
> 
> I don't know if this is suitable upstream, but it's one of the repo.or.cz
> custom modifications that I've thought could be interesting for others
> as well.
> 
> Compared to the previous patch, this adds the '.html' extension to the
> filename, so that it's clear it is, well, HTML.
> 
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---

Why not instead re-submit a patch implementing what was discussed in this thread bearing the same name:

http://marc.theaimsgroup.com/?t=116044914900001&r=1&w=2
     Luben
Show 28 quoted lines
> 
>  gitweb/gitweb.perl |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 3b26ec3..81adc71 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2538,6 +2538,14 @@ sub git_summary {
>  	}
>  	print "</table>\n";
>  
> +	if (-s "$projectroot/$project/README.html") {
> +		if (open my $fd, "$projectroot/$project/README.html") {
> +			print "<div class=\"title\">readme</div>\n";
> +			print $_ while (<$fd>);
> +			close $fd;
> +		}
> +	}
> +
>  	open my $fd, "-|", git_cmd(), "rev-list", "--max-count=17",
>  		git_get_head_hash($project)
>  		or die_error(undef, "Open git-rev-list failed");
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Petr Baudis· Oct 24, 2006, 11:30 UTC · re: Luben Tuikov · lore

Re: [PATCH] gitweb: Show project's README.html if available

Dear diary, on Tue, Oct 24, 2006 at 10:43:08AM CEST, I got a letter where Luben Tuikov <ltuikov@yahoo.com> said that...

Show 20 quoted lines
> --- Petr Baudis <pasky@suse.cz> wrote:
> > If the repository includes a README.html file, show it in the summary page.
> > The usual "this should be in the config file" argument does not apply here
> > since this can be larger and having such a big string in the config file
> > would be impractical.
> > 
> > I don't know if this is suitable upstream, but it's one of the repo.or.cz
> > custom modifications that I've thought could be interesting for others
> > as well.
> > 
> > Compared to the previous patch, this adds the '.html' extension to the
> > filename, so that it's clear it is, well, HTML.
> > 
> > Signed-off-by: Petr Baudis <pasky@suse.cz>
> > ---
> 
> Why not instead re-submit a patch implementing what was discussed
> in this thread bearing the same name:
> 
> http://marc.theaimsgroup.com/?t=116044914900001&r=1&w=2
This implements
	http://marc.theaimsgroup.com/?l=git&m=116047939517299&w=2

I see no other ideas I could take there except various naming proposals and perhaps using File::Copy but I'll wait until someone does a gitweb-wide change for the latter.

I don't really care _what_ name it bears, but I'd like to have it included. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

← back to recent threads