git/list[1] front-page[2] threads[3] people[4] search[5] about
 

BUG in fixup_pack_header_footer(...) / pack-write.c checksum error never raised

From
PTPaolo Teti <paolo.teti@gmail.com>
Date
May 15, 2007, 11:47 UTC
Message-ID
<34a7ae040705150447k2e770b5ag3629632f61b813a0@mail.gmail.com>

In fixup_pack_header_footer(...) file pack-write.c We have to change the size_t value returned by xread() in ssize_t, otherwise the next check on negative values has no sense.

size_t is an unsigned type!

I can't write now a patch because I'm on a customer site and I can't install GIT...

I'm just looking at the souce code using gitweb during a coffebreak.
Someone can fix it?..
Pao
Next: Johan Herland
Message 1 of 7 in “BUG in fixup_pack_header_footer(...) / pack-write.c checksum error never raised”
  1. Paolo TetiMay 15, 2007
  2. Fix signedness on return value from xread()Johan Herland, May 15, 2007
  3. Paolo TetiMay 15, 2007
  4. Ensure return value from xread() is always stored into an ssize_tJohan Herland, May 15, 2007
  5. Dana HowMay 15, 2007
  6. Johan HerlandMay 15, 2007
  7. Shawn O. PearceMay 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.