[PATCH] Fix signedness on return value from xread()

From: Johan Herland <johan@herland.net>
Date: May 15, 2007, 12:39 UTC
Message-ID: <200705151439.25871.johan@herland.net>
In-Reply-To: <34a7ae040705150447k2e770b5ag3629632f61b813a0@mail.gmail.com>

The return value from xread() is ssize_t. Paolo Teti <paolo.teti@gmail.com> pointed out that in this case, the signed return value was assigned to an unsigned type (size_t). This patch fixes that.

Signed-off-by: Johan Herland <johan@herland.net>
---

Using this as an opportunity to get used to sending patches... :)

Is this what you were looking for, Paolo?

 pack-write.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pack-write.c b/pack-write.c
index de72f44..ae2e481 100644
--- a/pack-write.c
+++ b/pack-write.c
@@ -25,7 +25,7 @@ void fixup_pack_header_footer(int pack_fd,
 
 	buf = xmalloc(buf_sz);
 	for (;;) {
-		size_t n = xread(pack_fd, buf, buf_sz);
+		ssize_t n = xread(pack_fd, buf, buf_sz);
 		if (!n)
 			break;
 		if (n < 0)

-- 
1.5.1.4