Re: [PATCH 2/6] http: always update the base URL for redirects
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Dec 1, 2016, 16:02 UTC
- Message-ID
- <331124b5-aa2b-773c-23ac-975ad3f50dbf@ramsayjones.plus.com>
- In-Reply-To
- <20161201090414.zgz7pimgpctghbwu@sigill.intra.peff.net>
On 01/12/16 09:04, Jeff King wrote:
Show 9 quoted lines
> If a malicious server redirects the initial ref > advertisement, it may be able to leak sha1s from other, > unrelated servers that the client has access to. For > example, imagine that Alice is a git user, she has access to > a private repository on a server hosted by Bob, and Mallory > runs a malicious server and wants to find out about Bob's > private repository. > > Mallory asks Alice to clone an unrelated repository from her
-----------------------------------------------------------^^^ ... from _him_ ? (ie Mallory)
Show 10 quoted lines
> over HTTP. When Alice's client contacts Mallory's server for > the initial ref advertisement, the server issues an HTTP > redirect for Bob's server. Alice contacts Bob's server and > gets the ref advertisement for the private repository. If > there is anything to fetch, she then follows up by asking > the server for one or more sha1 objects. But who is the > server? > > If it is still Mallory's server, then Alice will leak the > existence of those sha1s to her.
------------------------------^^^ ... to _him_ ? (again Mallory)
ATB, Ramsay Jones