Re: [PATCH 5/6] http: treat http-alternates like redirects

From: Brandon Williams <bmwill@google.com>
Date: Dec 1, 2016, 23:02 UTC
Message-ID: <20161201230223.GI54082@google.com>
In-Reply-To: <20161201090432.wtcu2jpacwcf6a4a@sigill.intra.peff.net>

On 12/01, Jeff King wrote:

>   - set CURLOPT_PROTOCOLS alongside CURLOPT_REDIR_PROTOCOLS
>     restrict ourselves to a known-safe set and respect any
>     user-provided whitelist.

Show 12 quoted lines

> diff --git a/http.c b/http.c
> index 825118481..051fe6e5a 100644
> --- a/http.c
> +++ b/http.c
> @@ -745,6 +745,7 @@ static CURL *get_curl_handle(void)
>  	if (is_transport_allowed("ftps"))
>  		allowed_protocols |= CURLPROTO_FTPS;
>  	curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS, allowed_protocols);
> +	curl_easy_setopt(result, CURLOPT_PROTOCOLS, allowed_protocols);
>  #else
>  	if (transport_restrict_protocols())
>  		warning("protocol restrictions not applied to curl redirects because\n"

Because I don't know much about how curl works....Only http/https/ftp/ftps protocols are allowed to be passed to curl? Is that because curl only understands those particular protocols?

-- 
Brandon Williams