Re: [PATCH 1/2] git-svn: don't append extra newlines at the end of commit messages.

From: Avery Pennarun <apenwarr@gmail.com>
Date: Jun 13, 2008, 16:23 UTC
Message-ID: <32541b130806130923x4c66f6ddybaaa5d7b00f6dead@mail.gmail.com>
In-Reply-To: <48522055.6060006@op5.se>

On 6/13/08, Andreas Ericsson <ae@op5.se> wrote:

Show 5 quoted lines

>  I'm not familiar with git-svn, and my perl is pretty weak as it is.
>  Are you proposing to remove extra whitespace from git commits when they are
>  sent back to svn via dcommit? If so, wouldn't it be better to always strip
>  extra newlines when importing from svn so they're never there in the first
>  place?

I thought of doing it that way (in fact, I *did* do it that way the first time). But I figured it would be too bad if you couldn't always reconstruct the precise svn commit message from the git commit message. Currently you can, even though you sometimes have to remove multiple newlines. Interestingly, the addition of the git-svn-id: line seems to be the only reason the commit messages aren't corrupted, since git normally trims whitespace from the end of its own commits.

So for the record, whether the sha1's would be affected after my patch didn't even occur to me. But it's very convenient that they're not.

Avery