Re: [PATCH 1/2] git-svn: don't append extra newlines at the end of commit messages.

From: Avery Pennarun <apenwarr@gmail.com>
Date: Jun 13, 2008, 16:17 UTC
Message-ID: <32541b130806130917y23a55751tfccac0de8143ebe4@mail.gmail.com>
In-Reply-To: <7vfxrhyjqd.fsf@gitster.siamese.dyndns.org>

On 6/13/08, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Avery Pennarun <apenwarr@gmail.com> writes:
>  > Instead, let's remove all trailing whitespace from the git commit on the way
>  > through to svn.
>
> Perl part of the code looks fine but I am unsure if we like the
>  ramifications of this patch on existing git-svn managed repositories.
>  Doesn't this change the commit object name on our end for almost all of
>  them?

Unless I got confused while coding this (I don't think I did), this should *not* affect existing or re-imported svn or git-svn repositories. It only removes trailing whitespace the first time a git commit is sent into svn, which should happen only once for a brand new commit by someone who has made it in git and is now dcommiting it to svn.

Naturally, the dcommit round-trip *always* produces a new sha1 hash for that commit anyhow because of the added git-svn-id: line. After this change, the sha1 will be different than it would have been before, but it will still be the same for anyone who checks out from svn again with git-svn.

Thanks,

Avery