git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] filter-branch: add new --blob-filter option.

From
Avery Pennarun <apenwarr@gmail.com>
Date
Jun 13, 2008, 16:10 UTC
Message-ID
<32541b130806130910w1975e092y192785fbab5c908@mail.gmail.com>
In-Reply-To
<20080613062546.GD26768@sigill.intra.peff.net>
On 6/13/08, Jeff King <peff@peff.net> wrote:
>   1. We're supposed to be in rc freeze, so this is not a great time to
>      publish a new feature. ;)

I thought that was what branches were for :) Anyway, I only rarely get the chance to work on this stuff lately, so I guess I got excited.

Show 5 quoted lines
>   2. When bringing back an old patch, please please please give at least
>      a little bit of cover letter context. "Here is what happened last
>      time, here are the reasons this patch was not accepted before, and
>      here is {why I think it that decision was wrong, what I have done
>      to improve the patch, etc}.
Will do next time.
Show 13 quoted lines
>  IIRC, the situation last time had two issues:
>
>   1. it was a one-off "we're not sure if this is really useful" patch
>
>   2. it was unclear whether paths should be available, and if they were,
>      there was an issue of encountering the same hash at two different
>      paths.
>
>  I assume your answer to '1' is "I have been using this and it is
>  useful". And for '2', it looks like you have extended the cache
>  mechanism to take into account the sha1 and the path, which I think is
>  the right solution (and I am pleased to see it looks like the final test
>  covers the exact situation I was concerned about).

Yes, for #1 it is indeed useful. I'm using git-svn on Windows with an IDE that auto-generates files with CRLF in them, and the translation of that is something roughly like "ARRGH!" I have to re-fix the newlines on various different branches at various times and this is the best way I've found. (Although I can also imagine using it for whitespace fixes, etc.)

You are correct about #2. I believe I've covered all the complaints that were brought up at the time.

Show 5 quoted lines
>  (for 1/3):
>  Signed-off-by: Jeff King <peff@peff.net>
>
>  (for the others (and for 1/3, do I get to ack my own patch?)):
>  Acked-by: Jeff King <peff@peff.net>
Thanks!
Avery
Previous: Jeff King
Message 5 of 5 in “filter-branch: add new --blob-filter option.”
  1. 1/3 filter-branch: add new --blob-filter option.Avery Pennarun, Jun 13, 2008
  2. 2/3 filter-branch --blob-filter: speed/flexibility improvements.Avery Pennarun, Jun 13, 2008
  3. 3/3 filter-branch --blob-filter: add tests.Avery Pennarun, Jun 13, 2008
  4. Jeff KingJun 13, 2008
  5. Avery PennarunJun 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.