Re: [PATCH v2 1/3] filter-branch: add new --blob-filter option.

From: Jeff King <peff@peff.net>
Date: Jun 13, 2008, 06:25 UTC
Message-ID: <20080613062546.GD26768@sigill.intra.peff.net>
In-Reply-To: <1213318344-26013-1-git-send-email-apenwarr@gmail.com>

On Thu, Jun 12, 2008 at 08:52:22PM -0400, Avery Pennarun wrote:

> It was easy enough to work up the patch below, which allows
> 
>   git filter-branch --blob-filter 'tr a-z A-Z'

First, two procedural complaints:

  1. We're supposed to be in rc freeze, so this is not a great time to
     publish a new feature. ;)

  2. When bringing back an old patch, please please please give at least
     a little bit of cover letter context. "Here is what happened last
     time, here are the reasons this patch was not accepted before, and
     here is {why I think it that decision was wrong, what I have done
     to improve the patch, etc}.

IIRC, the situation last time had two issues:

  1. it was a one-off "we're not sure if this is really useful" patch

  2. it was unclear whether paths should be available, and if they were,
     there was an issue of encountering the same hash at two different
     paths.

I assume your answer to '1' is "I have been using this and it is useful". And for '2', it looks like you have extended the cache mechanism to take into account the sha1 and the path, which I think is the right solution (and I am pleased to see it looks like the final test covers the exact situation I was concerned about).

So:

(for 1/3):
Signed-off-by: Jeff King <peff@peff.net>

(for the others (and for 1/3, do I get to ack my own patch?)):
Acked-by: Jeff King <peff@peff.net>

-Peff