git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer

From
Baz <brian.ewins@gmail.com>
Date
Sep 28, 2009, 10:36 UTC
Message-ID
<2faad3050909280336r61e11b20nb52629a8fe95b0c0@mail.gmail.com>
In-Reply-To
<bdca99240909260245i6ba10dd4j1b2ee9e74ea5282d@mail.gmail.com>
2009/9/26 Sebastian Schuberth <sschuberth@gmail.com>:
Show 9 quoted lines
> On Sat, Sep 26, 2009 at 02:05, Shawn O. Pearce <spearce@spearce.org> wrote:
>
>> Odd.  If I copy and paste from Thunderbird, its fine.  But if I
>> save the body out as an attachment from mutt, it fails.
>>
>> I wonder if it has to do with the From header appearing in the top
>> of the body; this header has to be escaped with a leading space in
>> mbox format.  It looks like Thunderbird might be doing some magic to
>> remove that leading space from the context lines, while mutt isn't.
FYI: the Thunderbird version included this header:
Content-Type:  text/plain; charset=ISO-8859-1; format=flowed

The format=flowed part shows that Thunderbird is reformatting whitespace. You can disable that: http://kb.mozillazine.org/Plain_text_e-mail_-_Thunderbird#Completely_plain_email

'flowed' is a lossy transformation of text, so git won't attempt to fix patches that have been mangled that way. There's a longer explanation from Junio here: http://kerneltrap.org/mailarchive/git/2008/2/15/867294

Hope this helps, Baz

Show 16 quoted lines
>>
>> Next time, don't include the first From line?
>
> Will try. So what about these two patches? Should I re-send them with
> the first "From" stripped?
>
> Or will *.patch files that are attached to emails, instead of sending
> the patch inline, be accepted?
>
> --
> Sebastian Schuberth
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Previous: Shawn O. PearceNext: Sebastian Schuberth
Message 11 of 16 in “Make generated MSVC solution file open from Windows Explorer”
  1. 1/2 Make generated MSVC solution file open from Windows ExplorerSebastian Schuberth, Sep 24, 2009
  2. Shawn O. PearceSep 25, 2009
  3. Alex RiesenSep 25, 2009
  4. Sebastian SchuberthSep 25, 2009
  5. Sebastian SchuberthSep 25, 2009
  6. Shawn O. PearceSep 25, 2009
  7. Sebastian SchuberthSep 25, 2009
  8. Shawn O. PearceSep 26, 2009
  9. Sebastian SchuberthSep 26, 2009
  10. Shawn O. PearceSep 26, 2009
  11. BazSep 28, 2009
  12. Sebastian SchuberthSep 28, 2009
  13. 0/2 MSVC generator fixupsMarius Storm-Olsen, Sep 28, 2009
  14. 1/2 Make generated MSVC solution file open from Windows ExplorerMarius Storm-Olsen, Sep 28, 2009
  15. 2/2 Make just opening the generated MSVC solution file not modify itMarius Storm-Olsen, Sep 28, 2009
  16. Sebastian SchuberthSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.