git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer

From
Shawn O. Pearce <spearce@spearce.org>
Date
Sep 25, 2009, 22:59 UTC
Message-ID
<20090925225940.GB14660@spearce.org>
In-Reply-To
<bdca99240909251541h2e9932a3r67c1d8604e56a8df@mail.gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> wrote:
Show 6 quoted lines
> On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Something is wrong with both patches; neither applies. ??It looks
> > to be an issue with whitespace, like context lines are gaining an
> > extra space at the start of the line.
> 
> Hmm, the patches apply fine onto master for me.
After going through your client and the GMane email gateway?
Or before you pasted it into the message?
Show 5 quoted lines
> As a side note, I've never liked sending patches via mail. It just
> feels like writing a text on a computer just to print it out, scan in
> the sheet again, and then sending the scanned image as an attachment
> via email. Isn't there a better way to contribute patches to Git, like
> pushing to a mob branch as for the msysGit project?

It works fine, so long as the tools in the chain leave the body of the message alone and don't try to outsmart the human who put it there.

The git project in particular as rules about only applying patches off the mailing list, because then all contributions are in a permanent, public archive. Its also the form of communication most contributors prefer for code reviews.

-- 
Shawn.
Previous: Sebastian SchuberthNext: Sebastian Schuberth
Message 6 of 16 in “Make generated MSVC solution file open from Windows Explorer”
  1. 1/2 Make generated MSVC solution file open from Windows ExplorerSebastian Schuberth, Sep 24, 2009
  2. Shawn O. PearceSep 25, 2009
  3. Alex RiesenSep 25, 2009
  4. Sebastian SchuberthSep 25, 2009
  5. Sebastian SchuberthSep 25, 2009
  6. Shawn O. PearceSep 25, 2009
  7. Sebastian SchuberthSep 25, 2009
  8. Shawn O. PearceSep 26, 2009
  9. Sebastian SchuberthSep 26, 2009
  10. Shawn O. PearceSep 26, 2009
  11. BazSep 28, 2009
  12. Sebastian SchuberthSep 28, 2009
  13. 0/2 MSVC generator fixupsMarius Storm-Olsen, Sep 28, 2009
  14. 1/2 Make generated MSVC solution file open from Windows ExplorerMarius Storm-Olsen, Sep 28, 2009
  15. 2/2 Make just opening the generated MSVC solution file not modify itMarius Storm-Olsen, Sep 28, 2009
  16. Sebastian SchuberthSep 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.