Re: [PATCH JGIT] fix typo
- From
Baz <brian.ewins@gmail.com>
- Date
- Feb 1, 2009, 12:42 UTC
- Message-ID
- <2faad3050902010442v6f64b804l79689245c6a60ff4@mail.gmail.com>
- In-Reply-To
- <1233411967.8213.4.camel@localhost>
2009/1/31 Yann Simon <yann.simon.fr@gmail.com>:
Show 18 quoted lines
> fix a little typo > Signed-off-by: Yann Simon <yann.simon.fr@gmail.com> > --- > .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > index 5eb8465..1ff8caa 100644 > --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > @@ -61,7 +61,7 @@ > * before any single byte can be accessed. > * </p> > * <p> > - * Using a specific MapMode will avoid the complete copy by mmaping in > the > + * Using a specific MapMode will avoid the complete copy by mapping in
Is this actually a typo? java.nio being used to mmap() files here (see the later use of mmap in this class), its more informative and common to use the double m to describe that. I'd have said the typo was at the end of the comment, ie "fast enough to permit new windows to be mapped." should read "fast enough to permit new windows to be mmapped."
Show 16 quoted lines
> the > * operating system's file buffers, however this may cause problems if > a large > * number of windows are being heavily accessed as the Java garbage > collector > * may not be able to unmap old windows fast enough to permit new > windows to be > -- > 1.6.0.6 > > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >