Re: [PATCH JGIT] fix typo

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Jan 31, 2009, 16:45 UTC
Message-ID: <200901311745.16803.robin.rosenberg@dewire.com>
In-Reply-To: <1233411967.8213.4.camel@localhost>

lördag 31 januari 2009 15:26:07 skrev Yann Simon:

Show 5 quoted lines

> fix a little typo
> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
> ---
>  .../src/org/spearce/jgit/lib/WindowedFile.java     |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Cleanups are nice too, but please try to follow the existing style when it comes to comments. I don't think we have stated these implicit rules anywhere.

- New sentences start with a capital letter.
- Don't repeat yourself You do not need a body in the comment 
if the first line says it all, except the SOB line which technically
is part of the body.
- Make sure there is an empty line before the SOB line.

Cheers,
	-- robin