git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/8] t5552: compensate for v2 filtering ref adv.

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Feb 6, 2019, 00:21 UTC
Message-ID
<2e8ad7ab247e6b14c0583f0800a228e95bcda095.1549411880.git.jonathantanmy@google.com>
In-Reply-To
<cover.1549411880.git.jonathantanmy@google.com>

Protocol v2 filters the ref advertisement, but protocol v0 does not. A test in t5552 uses the ref advertisement, so fix it to use protocol v0.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 t/t5552-skipping-fetch-negotiator.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t5552-skipping-fetch-negotiator.sh b/t/t5552-skipping-fetch-negotiator.sh
index 30857b84a8..8a14be51a1 100755
--- a/t/t5552-skipping-fetch-negotiator.sh
+++ b/t/t5552-skipping-fetch-negotiator.sh
@@ -127,7 +127,10 @@ test_expect_success 'use ref advertisement to filter out commits' '
 	# not need to send any ancestors of "c3", but we still need to send "c3"
 	# itself.
 	test_config -C client fetch.negotiationalgorithm skipping &&
-	trace_fetch client origin to_fetch &&
+
+	# The ref advertisement itself is filtered when protocol v2 is used, so
+	# use v0.
+	GIT_TEST_PROTOCOL_VERSION= trace_fetch client origin to_fetch &&
 	have_sent c5 c4^ c2side &&
 	have_not_sent c4 c4^^ c4^^^
 '
-- 
2.19.0.271.gfe8321ec05.dirty
Previous: Jonathan TanNext: Jonathan Tan
Message 16 of 26 in “Resend of GIT_TEST_PROTOCOL_VERSION patches”
  1. 0/8 Resend of GIT_TEST_PROTOCOL_VERSION patchesJonathan Tan, Feb 6, 2019
  2. 1/8 tests: define GIT_TEST_PROTOCOL_VERSIONJonathan Tan, Feb 6, 2019
  3. Ævar Arnfjörð BjarmasonFeb 6, 2019
  4. Jonathan TanFeb 7, 2019
  5. Jeff KingFeb 11, 2019
  6. 2/8 tests: always test fetch of unreachable with v0Jonathan Tan, Feb 6, 2019
  7. Jeff KingFeb 11, 2019
  8. Jonathan TanFeb 14, 2019
  9. Jeff KingFeb 21, 2019
  10. Junio C HamanoFeb 22, 2019
  11. Jeff KingFeb 23, 2019
  12. 3/8 t5503: fix overspecification of trace expectationJonathan Tan, Feb 6, 2019
  13. 4/8 t5512: compensate for v0 only sending HEAD symrefsJonathan Tan, Feb 6, 2019
  14. 5/8 t5700: only run with protocol version 1Jonathan Tan, Feb 6, 2019
  15. 6/8 tests: fix protocol version for overspecificationsJonathan Tan, Feb 6, 2019
  16. 7/8 t5552: compensate for v2 filtering ref adv.Jonathan Tan, Feb 6, 2019
  17. 8/8 remote-curl: in v2, fill credentials if neededJonathan Tan, Feb 6, 2019
  18. Jeff KingFeb 6, 2019
  19. Jonathan TanFeb 11, 2019
  20. Jeff KingFeb 11, 2019
  21. Jeff KingFeb 6, 2019
  22. Ævar Arnfjörð BjarmasonFeb 6, 2019
  23. Jeff KingFeb 6, 2019
  24. Ævar Arnfjörð BjarmasonFeb 6, 2019
  25. Jeff KingFeb 6, 2019
  26. Ævar Arnfjörð BjarmasonFeb 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.