git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/8] t5512: compensate for v0 only sending HEAD symrefs

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Feb 6, 2019, 00:21 UTC
Message-ID
<05b1b94c479760c17d38beafc3d45ad9a5a08d0d.1549411880.git.jonathantanmy@google.com>
In-Reply-To
<cover.1549411880.git.jonathantanmy@google.com>

Protocol v2 supports sending non-HEAD symrefs, but this is not true of protocol v0. Some tests expect protocol v0 behavior, so fix them to use protocol v0.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 t/t5512-ls-remote.sh | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh
index ced15ae122..e3c4a48c85 100755
--- a/t/t5512-ls-remote.sh
+++ b/t/t5512-ls-remote.sh
@@ -223,7 +223,9 @@ test_expect_success 'ls-remote --symref' '
 	$(git rev-parse refs/tags/mark1.10)	refs/tags/mark1.10
 	$(git rev-parse refs/tags/mark1.2)	refs/tags/mark1.2
 	EOF
-	git ls-remote --symref >actual &&
+	# Protocol v2 supports sending symrefs for refs other than HEAD, so use
+	# protocol v0 here.
+	GIT_TEST_PROTOCOL_VERSION= git ls-remote --symref >actual &&
 	test_cmp expect actual
 '
 
@@ -232,7 +234,9 @@ test_expect_success 'ls-remote with filtered symref (refname)' '
 	ref: refs/heads/master	HEAD
 	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	HEAD
 	EOF
-	git ls-remote --symref . HEAD >actual &&
+	# Protocol v2 supports sending symrefs for refs other than HEAD, so use
+	# protocol v0 here.
+	GIT_TEST_PROTOCOL_VERSION= git ls-remote --symref . HEAD >actual &&
 	test_cmp expect actual
 '
 
@@ -243,7 +247,9 @@ test_expect_failure 'ls-remote with filtered symref (--heads)' '
 	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/foo
 	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/master
 	EOF
-	git ls-remote --symref --heads . >actual &&
+	# Protocol v2 supports sending symrefs for refs other than HEAD, so use
+	# protocol v0 here.
+	GIT_TEST_PROTOCOL_VERSION= git ls-remote --symref --heads . >actual &&
 	test_cmp expect actual
 '
 
@@ -252,9 +258,11 @@ test_expect_success 'ls-remote --symref omits filtered-out matches' '
 	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/foo
 	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/master
 	EOF
-	git ls-remote --symref --heads . >actual &&
+	# Protocol v2 supports sending symrefs for refs other than HEAD, so use
+	# protocol v0 here.
+	GIT_TEST_PROTOCOL_VERSION= git ls-remote --symref --heads . >actual &&
 	test_cmp expect actual &&
-	git ls-remote --symref . "refs/heads/*" >actual &&
+	GIT_TEST_PROTOCOL_VERSION= git ls-remote --symref . "refs/heads/*" >actual &&
 	test_cmp expect actual
 '
 
-- 
2.19.0.271.gfe8321ec05.dirty
Previous: Jonathan TanNext: Jonathan Tan
Message 13 of 26 in “Resend of GIT_TEST_PROTOCOL_VERSION patches”
  1. 0/8 Resend of GIT_TEST_PROTOCOL_VERSION patchesJonathan Tan, Feb 6, 2019
  2. 1/8 tests: define GIT_TEST_PROTOCOL_VERSIONJonathan Tan, Feb 6, 2019
  3. Ævar Arnfjörð BjarmasonFeb 6, 2019
  4. Jonathan TanFeb 7, 2019
  5. Jeff KingFeb 11, 2019
  6. 2/8 tests: always test fetch of unreachable with v0Jonathan Tan, Feb 6, 2019
  7. Jeff KingFeb 11, 2019
  8. Jonathan TanFeb 14, 2019
  9. Jeff KingFeb 21, 2019
  10. Junio C HamanoFeb 22, 2019
  11. Jeff KingFeb 23, 2019
  12. 3/8 t5503: fix overspecification of trace expectationJonathan Tan, Feb 6, 2019
  13. 4/8 t5512: compensate for v0 only sending HEAD symrefsJonathan Tan, Feb 6, 2019
  14. 5/8 t5700: only run with protocol version 1Jonathan Tan, Feb 6, 2019
  15. 6/8 tests: fix protocol version for overspecificationsJonathan Tan, Feb 6, 2019
  16. 7/8 t5552: compensate for v2 filtering ref adv.Jonathan Tan, Feb 6, 2019
  17. 8/8 remote-curl: in v2, fill credentials if neededJonathan Tan, Feb 6, 2019
  18. Jeff KingFeb 6, 2019
  19. Jonathan TanFeb 11, 2019
  20. Jeff KingFeb 11, 2019
  21. Jeff KingFeb 6, 2019
  22. Ævar Arnfjörð BjarmasonFeb 6, 2019
  23. Jeff KingFeb 6, 2019
  24. Ævar Arnfjörð BjarmasonFeb 6, 2019
  25. Jeff KingFeb 6, 2019
  26. Ævar Arnfjörð BjarmasonFeb 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.