git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [tig PATCH 0/1] Make height of split view configurable

From
Jonas Fonseca <jonas.fonseca@gmail.com>
Date
Feb 25, 2009, 22:17 UTC
Message-ID
<2c6b72b30902251417s2f166910w4a47a2d1a43aef93@mail.gmail.com>
In-Reply-To
<cover.1235338009.git.tilo@tilo-schwarz.de>
On Mon, Feb 23, 2009 at 23:24,  <tilo@tilo-schwarz.de> wrote:
Show 7 quoted lines
> Rationale: On a large display with many rows it would be nice to be
> able to configure the heights of the views in the split view. For
> example, I like to have the lower diff view be 90% of the total
> view height.
>
> As it is, the patch lets the height of the lower view be configurable.
> Is it may be better to configure the height of the upper view?
I don't know, the way you have done it seems reasonable.
> Any input on variable nameing, code style etc. of course welcome.

Very, very clean and nicely done with the reusing of the parse/apply step code. Thanks.

-- 
Jonas Fonseca
Previous: tilo@tilo-schwarz.de
Message 3 of 3 in “Make height of split view configurable”
  1. 0/1 Make height of split view configurabletilo@tilo-schwarz.de, Feb 23, 2009
  2. 1/1 Make height of split view configurabletilo@tilo-schwarz.de, Feb 23, 2009
  3. Jonas FonsecaFeb 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.