From: Jonas Fonseca Date: Wed, 25 Feb 2009 22:17:25 GMT Subject: Re: [tig PATCH 0/1] Make height of split view configurable Message-ID: <2c6b72b30902251417s2f166910w4a47a2d1a43aef93@mail.gmail.com> In-Reply-To: On Mon, Feb 23, 2009 at 23:24, wrote: > Rationale: On a large display with many rows it would be nice to be > able to configure the heights of the views in the split view. For > example, I like to have the lower diff view be 90% of the total > view height. > > As it is, the patch lets the height of the lower view be configurable. > Is it may be better to configure the height of the upper view? I don't know, the way you have done it seems reasonable. > Any input on variable nameing, code style etc. of course welcome. Very, very clean and nicely done with the reusing of the parse/apply step code. Thanks. -- Jonas Fonseca