git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [ANNOUNCE] tig-0.14

From
Jonas Fonseca <fonseca@diku.dk>
Date
Feb 10, 2009, 20:41 UTC
Message-ID
<2c6b72b30902101241p67a0e1e9u60c8033c4a03260c@mail.gmail.com>
In-Reply-To
<d4bc1a2a0902101129y22224c89y144b223e7d7dd463@mail.gmail.com>

On Tue, Feb 10, 2009 at 20:29, Stefan Karpinski <stefan.karpinski@gmail.com> wrote:

Show 8 quoted lines
> On Tue, Feb 10, 2009 at 11:07 AM, Brian Gernhardt
> <benji@silverinsanity.com> wrote:
>>
>> OS 10.5.6's Terminal.app, with TERM=xterm-color
>> I have no .tigrc
>
> Ditto. Same bug. Completely vanilla tig setup. OS X Leopard,
> tig-0.14-9-gd06137e, TERM=xterm-color.

Looks like there might be a pattern and I might have an excuse to go knock on the door of one of my "Mac" friends. ;) However, first I would kindly ask if one of you have time to test the attached patch.

Thanks both of you and sorry for the inconvenience.
-- 
Jonas Fonseca


From 3670b9f20c49c46c6418d7dbcce8265b2fe8a853 Mon Sep 17 00:00:00 2001
From: Jonas Fonseca <fonseca@diku.dk>
Date: Tue, 10 Feb 2009 21:33:18 +0100
Subject: [PATCH] Fix regression where a line was not cleared when not selected anymore

Introduced in 273c28df2aa5cc0d122b1a0f3c0014a56ab8c392 (Tree view: make
drawing more smooth by using the dirty flag).
---
 tig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tig.c b/tig.c
index 7072094..02f4bd8 100644
--- a/tig.c
+++ b/tig.c
@@ -2055,7 +2055,7 @@ draw_view_line(struct view *view, unsigned int lineno)
 	line = &view->line[view->offset + lineno];
 
 	wmove(view->win, lineno, 0);
-	if (line->cleareol)
+	if (line->cleareol || (line->selected && !selected))
 		wclrtoeol(view->win);
 	view->col = 0;
 	view->curline = line;
-- 
1.6.1.1.347.g3f81d
Previous: Stefan KarpinskiNext: Brian Gernhardt
Message 34 of 69 in “[ANNOUNCE] tig-0.14”
  1. Jonas FonsecaFeb 5, 2009
  2. bill lamFeb 6, 2009
  3. Jonas FonsecaFeb 6, 2009
  4. Sitaram ChamartyFeb 6, 2009
  5. Jonas FonsecaFeb 8, 2009
  6. showing SHA1 of parent commit in tig [was Re: [ANNOUNCE] tig-0.14Sitaram Chamarty, Feb 11, 2009
  7. Jonas FonsecaFeb 12, 2009
  8. Sitaram ChamartyFeb 12, 2009
  9. Jeff KingFeb 6, 2009
  10. Jonas FonsecaFeb 6, 2009
  11. Jakub NarebskiFeb 6, 2009
  12. Jonas FonsecaFeb 8, 2009
  13. Jeff KingFeb 7, 2009
  14. Junio C HamanoFeb 7, 2009
  15. david@lang.hmFeb 7, 2009
  16. Jonas FonsecaFeb 8, 2009
  17. Jonas FonsecaFeb 8, 2009
  18. Jeff KingFeb 8, 2009
  19. Jonas FonsecaFeb 8, 2009
  20. Jeff KingFeb 7, 2009
  21. Jonas FonsecaFeb 8, 2009
  22. Jeff KingFeb 8, 2009
  23. Jonas FonsecaFeb 8, 2009
  24. Mikael MagnussonFeb 7, 2009
  25. Peter BaumannFeb 9, 2009
  26. Jeff KingFeb 9, 2009
  27. Peter BaumannFeb 9, 2009
  28. Jonas FonsecaFeb 10, 2009
  29. Jari AaltoFeb 10, 2009
  30. Ted PavlicFeb 10, 2009
  31. Jonas FonsecaFeb 10, 2009
  32. Brian GernhardtFeb 10, 2009
  33. Stefan KarpinskiFeb 10, 2009
  34. Jonas FonsecaFeb 10, 2009
  35. Brian GernhardtFeb 10, 2009
  36. Jonas FonsecaFeb 10, 2009
  37. Brian GernhardtFeb 10, 2009
  38. Ted PavlicFeb 11, 2009
  39. Jonas FonsecaFeb 12, 2009
  40. Ted PavlicFeb 11, 2009
  41. Ted PavlicFeb 20, 2009
  42. Jonas FonsecaFeb 20, 2009
  43. Ted PavlicFeb 20, 2009
  44. Jonas FonsecaFeb 20, 2009
  45. Jonas FonsecaFeb 25, 2009
  46. Ted PavlicFeb 11, 2009
  47. Ted PavlicFeb 11, 2009
  48. Ted PavlicFeb 11, 2009
  49. Jonas FonsecaFeb 12, 2009
  50. Tilo SchwarzFeb 12, 2009
  51. Jonas FonsecaFeb 12, 2009
  52. Tilo SchwarzFeb 12, 2009
  53. Jonas FonsecaFeb 15, 2009
  54. Sitaram ChamartyFeb 16, 2009
  55. Jonas FonsecaFeb 16, 2009
  56. Sitaram ChamartyFeb 16, 2009
  57. Thomas AdamFeb 16, 2009
  58. Jonas FonsecaFeb 16, 2009
  59. Marco CostalbaFeb 17, 2009
  60. Tilo SchwarzFeb 16, 2009
  61. Jonas FonsecaFeb 20, 2009
  62. Tilo SchwarzFeb 21, 2009
  63. Jonas FonsecaFeb 21, 2009
  64. Tilo SchwarzFeb 21, 2009
  65. Tilo SchwarzFeb 16, 2009
  66. bill lamFeb 13, 2009
  67. Jonas FonsecaFeb 13, 2009
  68. bill lamFeb 14, 2009
  69. Jonas FonsecaFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.