Re: [PATCH] tag: duplicate mention of --contains should mention --no-contains

From: Marc Branchaud <marcnarc@xiplink.com>
Date: May 15, 2017, 14:20 UTC
Message-ID: <28535adf-5f8f-a43d-82e9-2ada398637e2@xiplink.com>
In-Reply-To: <20170515122331.17348-1-avarab@gmail.com>

On 2017-05-15 08:23 AM, Ævar Arnfjörð Bjarmason wrote:

Show 21 quoted lines

> Fix a duplicate mention of --contains in the SYNOPSIS to mention
> --no-contains.
>
> This fixes an error introduced in my commit ac3f5a3468 ("ref-filter:
> add --no-contains option to tag/branch/for-each-ref", 2017-03-24).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Documentation/git-tag.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
> index f8a0b787f4..1eb15afa1c 100644
> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -12,7 +12,7 @@ SYNOPSIS
>  'git tag' [-a | -s | -u <keyid>] [-f] [-m <msg> | -F <file>]
>  	<tagname> [<commit> | <object>]
>  'git tag' -d <tagname>...
> -'git tag' [-n[<num>]] -l [--contains <commit>] [--contains <commit>]
> +'git tag' [-n[<num>]] -l [--contains <commit>] [--no-contains <commit>]

I think

	[--[no-]contains <commit>]

is the usual pattern...

>  	[--points-at <object>] [--column[=<options>] | --no-column]
>  	[--create-reflog] [--sort=<key>] [--format=<format>]
>  	[--[no-]merged [<commit>]] [<pattern>...]

... like with --[no-]merged, there.

M.