Re: [PATCH] t3920: don't ignore errors of more than one command with `|| true`

From: Johannes Sixt <j6t@kdbg.org>
Date: Nov 22, 2022, 22:37 UTC
Message-ID: <271dd9e6-3575-a46f-4c92-fa202aaf95d7@kdbg.org>
In-Reply-To: <221122.86mt8iaamz.gmgdl@evledraar.gmail.com>

Am 22.11.22 um 23:24 schrieb Ævar Arnfjörð Bjarmason:

Show 10 quoted lines

> On Mon, Nov 21 2022, Johannes Sixt wrote:
>> -	grep 'Body' .crlf-message-$branch.txt >.crlf-body-$branch.txt || true &&
>> +	{ grep 'Body' .crlf-message-$branch.txt >.crlf-body-$branch.txt || true; } &&
> 
> Any reason not to make this:
> 
> 	-       grep 'Body' .crlf-message-$branch.txt >.crlf-body-$branch.txt || true &&
> 	+       sed -ne '/Body/p' <.crlf-message-$branch.txt >.crlf-body-$branch.txt &&
> 
> ?

Yes: I have tested my version, but not this one.

-- Hannes