Re: [PATCH 2/1] t3920: support CR-eating grep

From: René Scharfe <l.s.r@web.de>
Date: Dec 5, 2022, 10:43 UTC
Message-ID: <26ed832d-fb97-c0ef-3848-f58ea574a23f@web.de>
In-Reply-To: <xmqqwn76p55v.fsf@gitster.g>

Am 05.12.22 um 10:32 schrieb Junio C Hamano:

Show 16 quoted lines

> René Scharfe <l.s.r@web.de> writes:
>
>> Depends on the meaning of "fixed".  If it stops removing CRs then this
>> line is unaffected -- .crlf-orig-$branch.txt contains no CRs.
>
> OK, that "fix" was what I was worried about and if there is no
> problem with the input we use, that is good ;-)
>
>> If it
>> starts adding CRs then we'd have a problem with all grep invocations,
>> which was addressed by 4d715ac05c (Windows: a test_cmp that is agnostic
>> to random LF <> CRLF conversions, 2013-10-26).
>
> Yeah, but I thought that the unspoken motivation behind recent
> changes are so that we do not have to rely on "the differences
> between CRLF and LF do not matter" version of test_cmp?

The patch currently enables the removal of mingw_test_cmp; its commit message mentions it in passing ("[...] especially since this is the only test that needs it."). If grep (or bash) would be "fixed" to add CRs then we'd have to deal with that damage e.g. by keeping mingw_test_cmp.

René