git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle: verify arguments more strictly

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 8, 2015, 08:11 UTC
Message-ID
<239a633b6bbed03e92318322ce566295@www.dscho.org>
In-Reply-To
<1431071341-23363-1-git-send-email-ps@pks.im>
Hi Patrick,
On 2015-05-08 09:49, Patrick Steinhardt wrote:
Show 7 quoted lines
> The `verify` and `create` subcommands of the bundle builtin do
> not properly verify the command line arguments that have been
> passed in. While the `verify` subcommand accepts an arbitrary
> amount of ignored arguments the `create` subcommand does not
> complain about being passed too few arguments, resulting in a
> bogus call to `git rev-list`. Fix these errors by verifying that
> the correct amount of arguments has been passed in.
Good catch. But please sign off your patch [*1*]
Other than that...
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Ciao, Johannes

Footnote *1*: Here is why you need to sign off on your patches: https://github.com/git/git/blob/v2.3.5/Documentation/SubmittingPatches#L234-L286
Previous: Johannes Schindelin
Message 4 of 4 in “bundle: verify arguments more strictly”
  1. bundle: verify arguments more strictlyPatrick Steinhardt, May 8, 2015
  2. bundle: verify arguments more strictlyPatrick Steinhardt, May 8, 2015
  3. Johannes SchindelinMay 8, 2015
  4. Johannes SchindelinMay 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.