From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 08 May 2015 08:11:08 GMT
Subject: Re: [PATCH] bundle: verify arguments more strictly
Message-ID: <239a633b6bbed03e92318322ce566295@www.dscho.org>
In-Reply-To: <1431071341-23363-1-git-send-email-ps@pks.im>

Hi Patrick,

On 2015-05-08 09:49, Patrick Steinhardt wrote:
> The `verify` and `create` subcommands of the bundle builtin do
> not properly verify the command line arguments that have been
> passed in. While the `verify` subcommand accepts an arbitrary
> amount of ignored arguments the `create` subcommand does not
> complain about being passed too few arguments, resulting in a
> bogus call to `git rev-list`. Fix these errors by verifying that
> the correct amount of arguments has been passed in.

Good catch. But please sign off your patch [*1*]

Other than that...
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Ciao,
Johannes

Footnote *1*: Here is why you need to sign off on your patches: https://github.com/git/git/blob/v2.3.5/Documentation/SubmittingPatches#L234-L286