Re: git-bisect: weird usage of read(1)

From: Mikael Magnusson <mikachu@gmail.com>
Date: Aug 11, 2008, 14:16 UTC
Message-ID: <237967ef0808110716l2a0a2a4je22c2a1b8c239f57@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0808111615260.24820@pacific.mpi-cbg.de.mpi-cbg.de>

2008/8/11 Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 15 quoted lines

> Hi,
>
> On Mon, 11 Aug 2008, Francis Moreau wrote:
>
>> I found this in git bisect:
>>
>>               printf >&2 'Are you sure [Y/n]? '
>>               case "$(read yesno)" in [Nn]*) exit 1 ;; esac
>>
>> which looks very weird since read(1) returns a status and not the
>> string reads from std input.
>>
>> Am I missing something ?
>
> Yes.  "$()" does not return the status, but the output.

But there is no output, since read doesn't print anything... case "$(read yesno; echo $yesno)" in [Nn]*) could work, but looks a bit strange. read yesno; case $yesno in [Nn]*) would be the usual way to do things i think?

-- 
Mikael Magnusson