Re: [PATCH 2/2] maintenance: add option to register in a specific config

From: Derrick Stolee <derrickstolee@github.com>
Date: Nov 7, 2022, 20:49 UTC
Message-ID: <22a74e0f-f389-7b9c-f2cc-b3581c246c75@github.com>
In-Reply-To: <20221105184532.457043-3-ronan@rjp.ie>

On 11/5/22 2:45 PM, Ronan Pigott wrote:

Show 5 quoted lines

> maintenance register currently records the maintenance repo exclusively
> within the user's global configuration, but other configuration files
> may be relevant when running maintenance if they are included from the
> global config. This option allows the user to choose where maintenance
> repos are recorded.

Taylor already provided most of the feedback that I would have given.

>  static char const * const builtin_maintenance_register_usage[] = {
> -	"git maintenance register",
> +	"git maintenance register [--config <file>]",

The only recommendation I have remaining is to rename this option to `--config-file=<file>` since it is unclear from just "--config" if it is a config _file_ or a config _key_.

Thanks, -Stolee