Re: [PATCH 1/2] for-each-repo: interpolate repo path arguments
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Nov 7, 2022, 20:46 UTC
- Message-ID
- <15d9326c-8a32-c11c-53b0-cf399e541a48@github.com>
- In-Reply-To
- <Y2cAFSR83bjFFcq/@nand.local>
On 11/5/22 8:30 PM, Taylor Blau wrote:
Show 15 quoted lines
> On Sat, Nov 05, 2022 at 11:45:31AM -0700, Ronan Pigott wrote: >> This is a quality of life change for git-maintenance, so repos can be >> recorded with the tilde syntax. The register subcommand will not record >> repos in this format by default. >> >> Signed-off-by: Ronan Pigott <ronan@rjp.ie> >> --- >> builtin/for-each-repo.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Seems reasonable. So the 'register' subcommand will never write a record > that isn't an absolute path, but a user may manually munge the > maintenance configuration and we want to err on the side of flexibility. > > OK, sounds good. Missing test, though?
I agree that this implementation looks good, but a test would be helpful to be sure.
Thanks, -Stolee