git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib/scalar: fix 'all' target in Makefile

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 6, 2022, 08:21 UTC
Message-ID
<220406.861qyafwer.gmgdl@evledraar.gmail.com>
In-Reply-To
<pull.1205.git.1649198136190.gitgitgadget@gmail.com>
On Tue, Apr 05 2022, Victoria Dye via GitGitGadget wrote:
Show 7 quoted lines
> From: Victoria Dye <vdye@github.com>
>
> Add extra ':' to second 'all' target definition to allow 'scalar' to build.
> Without this fix, the 'all:' and 'all::' targets together cause a build
> failure when 'scalar' build is enabled with 'INCLUDE_SCALAR':
>
>     Makefile:14: *** target file `all' has both : and :: entries.  Stop.
Thanks for the fix, and sorry.

I missed this because I build and install scalar locally with a patch on top[1] to integrate it into the main Makefile, so I wasn't running this part, even if I was building, testing and installing it as part of my local build.

1. https://lore.kernel.org/git/patch-1.1-86fb8d56307-20211028T185016Z-avarab@gmail.com/
Previous: Victoria Dye via GitGitGadget
Message 2 of 2 in “contrib/scalar: fix 'all' target in Makefile”
  1. contrib/scalar: fix 'all' target in MakefileVictoria Dye via GitGitGadget, Apr 5, 2022
  2. Ævar Arnfjörð BjarmasonApr 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.