From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 06 Apr 2022 08:21:14 GMT
Subject: Re: [PATCH] contrib/scalar: fix 'all' target in Makefile
Message-ID: <220406.861qyafwer.gmgdl@evledraar.gmail.com>
In-Reply-To: <pull.1205.git.1649198136190.gitgitgadget@gmail.com>


On Tue, Apr 05 2022, Victoria Dye via GitGitGadget wrote:

> From: Victoria Dye <vdye@github.com>
>
> Add extra ':' to second 'all' target definition to allow 'scalar' to build.
> Without this fix, the 'all:' and 'all::' targets together cause a build
> failure when 'scalar' build is enabled with 'INCLUDE_SCALAR':
>
>     Makefile:14: *** target file `all' has both : and :: entries.  Stop.

Thanks for the fix, and sorry.

I missed this because I build and install scalar locally with a patch on
top[1] to integrate it into the main Makefile, so I wasn't running this
part, even if I was building, testing and installing it as part of my
local build.

1. https://lore.kernel.org/git/patch-1.1-86fb8d56307-20211028T185016Z-avarab@gmail.com/