Re: [PATCH v2 2/7] core.fsyncmethod: batched disk flushes for loose-objects
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Mar 21, 2022, 14:41 UTC
- Message-ID
- <220321.86a6dj9xja.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <3ed1dcd9b9ba9b34f26b3012eaba8da0269ee842.1647760560.git.gitgitgadget@gmail.com>
On Sun, Mar 20 2022, Neeraj Singh via GitGitGadget wrote:
Show 6 quoted lines
> From: Neeraj Singh <neerajsi@microsoft.com>
> [...]
> + if (batch_fsync_enabled(FSYNC_COMPONENT_LOOSE_OBJECT)) {
> + bulk_fsync_objdir = tmp_objdir_create("bulk-fsync");
> + if (!bulk_fsync_objdir)
> + die(_("Could not create temporary object directory for core.fsyncobjectfiles=batch"));Should camel-case the config var, and we should have a die_errno() here which tell us why we couldn't create it (possibly needing to ferry it up from the tempfile API...)