ja/i18n-common-messages (was: What's cooking in git.git (Feb 2022, #01; Thu, 3))
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 4, 2022, 12:29 UTC
- Message-ID
- <220204.86iltu3jbm.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <xmqqr18jnr2t.fsf@gitster.g>
On Thu, Feb 03 2022, Junio C Hamano wrote:
Show 11 quoted lines
> * ja/i18n-common-messages (2022-01-31) 5 commits > - i18n: fix some misformated placeholders in command synopsis > - i18n: remove from i18n strings that do not hold translatable parts > - i18n: factorize "invalid value" messages > - SQUASH??? > - i18n: factorize more 'incompatible options' messages > > Unify more messages to help l10n. > > Will merge to 'next' after squashing the fix-up in. > source: <pull.1123.v4.git.1643666870.gitgitgadget@gmail.com>
I had a comment on the API direction in parse-options.c, which I think should be done differently, but I also think it would be fine to just change it up later:
https://lore.kernel.org/git/220201.86a6fa9tmr.gmgdl@evledraar.gmail.com/
I replied to v2 instead of v4 due to some (now fixed) mail delays at the time, but that comment still applies to the latest version.