git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] builtin/history: unuse the commit buffer after use

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Sep 10, 2026, 16:37 UTC
Message-ID
<20d607c2-2380-4d52-86b2-25016574abdb@gmail.com>
In-Reply-To
<20260910160254.GB251185@coredump.intra.peff.net>
On 9/10/26 21:32, Jeff King wrote:
Show 6 quoted lines
> On Thu, Sep 10, 2026 at 08:30:15PM +0530, Kaartic Sivaraam wrote:
> 
> I'm not suggesting a v3 with this wording, as I think there are
> diminishing returns to polishing commit messages forever. Mostly just
> food for thought for future patches. :)
> 

That was very helpful, thanks! I suppose I've lost touch with writing patches for this community. I tried to beef it up hoping that more context / clarity is always useful. OTOH, I definitely agree that fewer words to convey the same is always better. Will try to improve in the patches to come :-)

That said, I don't mind sending a v4 with your proposed message as it is a strict improvement, though.

-- 
Sivaraam
Previous: Junio C HamanoNext: Kaartic Sivaraam
Message 16 of 17 in “builtin/history: unuse the commit buffer after use”
  1. builtin/history: unuse the commit buffer after useKaartic Sivaraam, Jun 14, 2026
  2. Patrick SteinhardtJun 15, 2026
  3. Jeff KingJun 15, 2026
  4. Patrick SteinhardtJun 16, 2026
  5. Kaartic SivaraamJun 30, 2026
  6. Jeff KingJun 30, 2026
  7. Kaartic SivaraamJun 30, 2026
  8. Jeff KingJun 30, 2026
  9. Jeff KingJun 30, 2026
  10. Jeff KingJun 30, 2026
  11. builtin/history: unuse the commit buffer after useKaartic Sivaraam, Sep 10, 2026
  12. Junio C HamanoSep 10, 2026
  13. builtin/history: unuse the commit buffer after useKaartic Sivaraam, Sep 10, 2026
  14. Jeff KingSep 10, 2026
  15. Junio C HamanoSep 10, 2026
  16. Kaartic SivaraamSep 10, 2026
  17. builtin/history: unuse the commit buffer after useKaartic Sivaraam, Sep 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.