Re: [PATCH] builtin/history: unuse the commit buffer after use
- From
Jeff King <peff@peff.net>
- Date
- Jun 30, 2026, 05:50 UTC
- Message-ID
- <20260630055026.GE2495216@coredump.intra.peff.net>
- In-Reply-To
- <20260630053825.GC2495216@coredump.intra.peff.net>
On Tue, Jun 30, 2026 at 01:38:25AM -0400, Jeff King wrote:
Show 5 quoted lines
> Try: > > make SANITIZE=leak > cd t > GIT_TEST_COMMIT_GRAPH=1 ./t3451-history-reword.sh -v -i
Of course that made me curious how a full run of the test suite would react to that flag. We get a few failures of t345x tests, but they all look like the same leak discussed here.
t4014 also fails, but with a unique leak. I don't think it's the same thing; it looks like we may leak the slab from init_topo_walk().
-Peff