git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] i18n: remove i18n from tag reflog message

From
Jean-Noël AVILA <jn.avila@free.fr>
Date
May 3, 2017, 16:38 UTC
Message-ID
<2070499.EYhsb04HyH@cayenne>
In-Reply-To
<xmqqwpa1ic4e.fsf@gitster.mtv.corp.google.com>
Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
Show 13 quoted lines
> Jean-Noel Avila <jn.avila@free.fr> writes:
> > The building of the reflog message is using strbuf, which is not
> > friendly with internationalization frameworks. No other reflog
> > messages are translated right now and switching all the messages to
> > i18n would require a major rework of the way the messages are built.
> 
> Thanks for spotting.  Before we declare that reflog messages are for
> i18n, we'd need to either drop (or redesign the implementation of)
> the "checkout -" feature, which relies on the exact phrasing of how
> reflog entries from "git checkout" looks like.
> 
> Will queue and merge down to 'master' quickly.
> 

I didn't know this "side effect". Maybe adding a test against it would be requiered. Unfortunately, I don't know enough of it.

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 9 in “i18n: remove i18n from tag reflog message”
  1. i18n: remove i18n from tag reflog messageJean-Noel Avila, Apr 29, 2017
  2. i18n patches to apply for rc2Jean-Noel Avila, Apr 30, 2017
  3. 1/2 i18n: remove i18n from tag reflog messageJean-Noel Avila, Apr 30, 2017
  4. 2/2 i18n: read-cache: Fix typoJean-Noel Avila, Apr 30, 2017
  5. Junio C HamanoMay 1, 2017
  6. Jean-Noël AVILAMay 3, 2017
  7. Junio C HamanoMay 4, 2017
  8. Junio C HamanoMay 4, 2017
  9. Ævar Arnfjörð BjarmasonMay 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.