From: Jean-Noël AVILA <jn.avila@free.fr>
Date: Wed, 03 May 2017 16:38:45 GMT
Subject: Re: [PATCH] i18n: remove i18n from tag reflog message
Message-ID: <2070499.EYhsb04HyH@cayenne>
In-Reply-To: <xmqqwpa1ic4e.fsf@gitster.mtv.corp.google.com>

Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
> Jean-Noel Avila <jn.avila@free.fr> writes:
> > The building of the reflog message is using strbuf, which is not
> > friendly with internationalization frameworks. No other reflog
> > messages are translated right now and switching all the messages to
> > i18n would require a major rework of the way the messages are built.
> 
> Thanks for spotting.  Before we declare that reflog messages are for
> i18n, we'd need to either drop (or redesign the implementation of)
> the "checkout -" feature, which relies on the exact phrasing of how
> reflog entries from "git checkout" looks like.
> 
> Will queue and merge down to 'master' quickly.
> 

I didn't know this "side effect". Maybe adding a test against it would be 
requiered. Unfortunately, I don't know enough of it.