git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] unit-tests: reshuffle NOOP arguments to maintain order

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Oct 26, 2026, 07:18 UTC
Message-ID
<20261026-ks-unit-tests-ignore-long-tests-v2-1-eaab5657c19c@gmail.com>
In-Reply-To
<20261026-ks-unit-tests-ignore-long-tests-v2-0-eaab5657c19c@gmail.com>

Ever since 9faf3963b6 (t: introduce compatibility options to clar-based tests, 2024-12-13), our clar tests have a few NOOP arguments in order to accept the same arguments that our integration tests accept. This makes it easy to pass in test arguments when both unit and integration tests are run together such as via:

  $ meson test -v --test-args='-ix'

On a quick scan, the order of the NOOP arguments seem to be alphabetical. That is only until you notice that 'with-dashes' appears out of order.

Fix this by moving it into its appropriate place thus ensuring they are in alphabetical order. This makes it easy for future patches to not worry about where to place a NOOP argument that is not yet in the list.

Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
---
 t/unit-tests/unit-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
index 752fb38fb3..d066c8a4c8 100644
--- a/t/unit-tests/unit-test.c
+++ b/t/unit-tests/unit-test.c
@@ -33,12 +33,12 @@ int cmd_main(int argc, const char **argv)
 		OPT_NOOP_ARG(0, "root"),
 		OPT_NOOP_ARG(0, "stress"),
 		OPT_NOOP_NOARG(0, "tee"),
-		OPT_NOOP_NOARG(0, "with-dashes"),
 		OPT_NOOP_ARG(0, "valgrind"),
 		OPT_NOOP_ARG(0, "valgrind-only"),
 		OPT_NOOP_NOARG('v', "verbose"),
 		OPT_NOOP_NOARG('V', "verbose-log"),
 		OPT_NOOP_ARG(0, "verbose-only"),
+		OPT_NOOP_NOARG(0, "with-dashes"),
 		OPT_NOOP_NOARG('x', NULL),
 		OPT_END(),
 	};
-- 
2.56.0.99.g5a7d1e8045.dirty
Previous: Kaartic SivaraamNext: Kaartic Sivaraam
Message 2 of 3 in “Make our clar tests ignore the long-tests argument”
  1. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 26, 2026
  2. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 26, 2026
  3. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.