git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Make our clar tests ignore the long-tests argument

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Oct 26, 2026, 07:18 UTC
Message-ID
<20261026-ks-unit-tests-ignore-long-tests-v2-0-eaab5657c19c@gmail.com>

This is a small patch to fix a hiccup I hit while trying to run our test using the following incantation:

  $ meson test -v --test-args='-ilx'
  ...
  Summary of Failures:
     2/1063 unit-tests                                     FAIL            0.16s   (exit status 129 or signal 1 SIGHUP)
  Ok:                 1061
  Expected Fail:      0
  Fail:               1
  Unexpected Pass:    0
  Skipped:            1
  Timeout:            0
  Full log written to /path/to/testlog.txt
On some exploration, we find the following which shows us what's wrong:
  2/1063 unit-tests RUNNING       
  >>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=103 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /me/git-1/build/t/unit-tests -ilx
  ――――――――――――――――――――――――――――――――――――――――――――――― ✀  ――――――――――――――――――――――――――――――――――――――――――――――――
  error: unknown switch `l'
  usage: unit-test [<options>]
      -i, --[no-]immediate  immediately exit upon the first failed test
      -r, --[no-]run suite[::test]
                            run only test suite or individual test <suite[::test]>
      --[no-]exclude <suite>
                            exclude test suite <suite>
  ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
  2/1063 unit-tests FAIL            0.01s   (exit status 129 or signal 1 SIGHUP)
So, the '-l' switch that's passed to unit-tests is the problem.

On searching for how these were handled before, I stumbled across 9faf3963b6 (t: introduce compatibility options to clar-based tests, 2024-12-13) which handled this by adding such arguments as NOOP arguments to t/unit-tests/unit-test.c. So, this patch does the same to make unit-test ignore the '-l' passed to it.

The CI pipeline passes (for v1. v2 only had a commit message change):
 - GitHub: https://github.com/sivaraam/git/actions/runs/39756087806
   (a couple of MacOS ones didn't run owing to the lack of a runner)
- GitLab: https://gitlab.com/gitlab-org/git/-/pipelines/2975804623
---
Changes in v2:
- Fixed the s/prerequiiste/prerequisite/ typo in the commit message
- Link to v1: https://lore.kernel.org/r/20261022-ks-unit-tests-ignore-long-tests-v1-0-554a590d418b@gmail.com
Range-diff vs. v1:
1:  66759f627c = 1:  60bc3f0d83 unit-tests: reshuffle NOOP arguments to maintain order
2:  0bea06fe46 ! 2:  c39dd72a2b unit-tests: ignore --long-tests
    @@ Commit message
         So, ignore -l / --long-tests in our clar tests.
         This does not show up as a problem while running our CI as we enable
    -    the expensive prerequiiste via the GIT_TEST_LONG env variable.
    +    the expensive prerequisite via the GIT_TEST_LONG env variable.
         Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
---
Kaartic Sivaraam (2):
      unit-tests: reshuffle NOOP arguments to maintain order
      unit-tests: ignore --long-tests
 t/unit-tests/unit-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

${range_diff} --- base-commit: 47fdf2208c5b94c8cc01c106b8f7c85efb91c926 change-id: 20261021-ks-unit-tests-ignore-long-tests-9f32078e9100 ${prerequisites}

Next: Kaartic Sivaraam
Message 1 of 3 in “Make our clar tests ignore the long-tests argument”
  1. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 26, 2026
  2. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 26, 2026
  3. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.