Re: [PATCH v3 2/2] merge-ll: use tempfile API for external driver files

From: Jeff King <peff@peff.net>
Date: Sep 29, 2026, 18:25 UTC
Message-ID: <20260929182537.GA1710046@coredump.intra.peff.net>
In-Reply-To: <xmqqcxtwhufq.fsf@gitster.g>

On Tue, Sep 29, 2026 at 09:51:53AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> > If we were starting from scratch, I'd say the correct solution here is
> > to shell-quote the filenames we put in the command. But doing so isn't
> > strictly backwards compatible, because users might have their own shell
> > characters. For example, if I configure a driver like this:
> 
> "own shell characters" -> "own shell quoting"?

Hmm, yeah. I was thinking that our quoting could disrupt other shell metacharacters they used. But I guess if it is only surrounding the filenames we provide, only their quoting characters could matter. So if they wrote:

  --option='%A'
  '--option=%A'
  --option="%A"

and so forth.

-Peff