git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] reftable/stack: avoid reloading the stack when already locked

From
Jeff King <peff@peff.net>
Date
Aug 24, 2026, 04:59 UTC
Message-ID
<20260824045922.GC142844@coredump.intra.peff.net>
In-Reply-To
<CAOLa=ZQpeCKzQ3EVXQEhfxL1khUH0YD6_Kc1qDQhxoN926rsBw@mail.gmail.com>
On Sun, Aug 23, 2026 at 01:39:48PM -0400, Karthik Nayak wrote:
Show 10 quoted lines
> I can reproduce your results locally too. I was a bit stumbled why,
> I was using a modified version of our benchmarks repository [1], which
> was using a fixed static target.
> 
> The difference was I was updating 'refs/heads/*' and your script does
> 'refs/tags/*'. The difference is in `should_write_log()`, where for
> LOG_REFS_NORMAL and 'refs/heads/*' we shortcut to creating the logs.
> While for tags, we do a check to see reflog already exists. This causes
> a stack reload (before my patches). This shows the significant
> difference in our benchmarks.

Ah, yeah. The refs/heads/ case should already have been fast, at least for the default config. Makes sense.

-Peff
Previous: Karthik Nayak
Message 17 of 17 in “reftable/stack: avoid reloading the stack when locked”
  1. 0/3 reftable/stack: avoid reloading the stack when lockedKarthik Nayak, Aug 19, 2026
  2. 1/3 reftable/stack: remove `REFTABLE_STACK_NEW_ADDITION_RELOAD`Karthik Nayak, Aug 19, 2026
  3. Justin ToblerAug 19, 2026
  4. Karthik NayakAug 20, 2026
  5. Patrick SteinhardtAug 20, 2026
  6. Karthik NayakAug 20, 2026
  7. Karthik NayakAug 20, 2026
  8. 2/3 reftable/stack: move list lock to `struct reftable_stack`Karthik Nayak, Aug 19, 2026
  9. Justin ToblerAug 19, 2026
  10. Junio C HamanoAug 19, 2026
  11. Karthik NayakAug 23, 2026
  12. 3/3 reftable/stack: avoid reloading the stack when already lockedKarthik Nayak, Aug 19, 2026
  13. Justin ToblerAug 19, 2026
  14. Karthik NayakAug 23, 2026
  15. Jeff KingAug 20, 2026
  16. Karthik NayakAug 23, 2026
  17. Jeff KingAug 24, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.