From: Jeff King Date: Mon, 24 Aug 2026 04:59:22 GMT Subject: Re: [PATCH 3/3] reftable/stack: avoid reloading the stack when already locked Message-ID: <20260824045922.GC142844@coredump.intra.peff.net> In-Reply-To: On Sun, Aug 23, 2026 at 01:39:48PM -0400, Karthik Nayak wrote: > I can reproduce your results locally too. I was a bit stumbled why, > I was using a modified version of our benchmarks repository [1], which > was using a fixed static target. > > The difference was I was updating 'refs/heads/*' and your script does > 'refs/tags/*'. The difference is in `should_write_log()`, where for > LOG_REFS_NORMAL and 'refs/heads/*' we shortcut to creating the logs. > While for tags, we do a check to see reflog already exists. This causes > a stack reload (before my patches). This shows the significant > difference in our benchmarks. Ah, yeah. The refs/heads/ case should already have been fast, at least for the default config. Makes sense. -Peff