git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] chdir-notify.h: Removed unused param 'name'

From
Jeff King <peff@peff.net>
Date
Aug 15, 2026, 05:12 UTC
Message-ID
<20260815051213.GA26013@coredump.intra.peff.net>
In-Reply-To
<20260814214210.1625-1-colinlewishinton@gmail.com>
On Fri, Aug 14, 2026 at 02:42:10PM -0700, Colin Hinton wrote:
Show 16 quoted lines
> The `name` parameter in `chdir_notify_entry` was only ever used by
> chdir_notify_reparent() to produce trace output. That function was
> removed in 5bf546755c (chdir-notify: drop unused
> `chdir_notify_reparent()`, 2026-06-25), which left `name` with no
> remaining consumers.
> 
> Prior to that removal, most callers had already stopped passing a
> meaningful name, switching to NULL in 1f43ff2c7e (refs: unregister
> reference stores from "chdir_notify", 2026-06-25) and 0de2467e6c
> (odb/source-packed: start converting to a proper `struct odb_source`,
> 2026-06-17).
> 
> Since no caller has populated `name` with real data for some time,
> and its last consumer is gone, drop it from chdir_notify_register(),
> chdir_notify_unregister(), and the callback signature to simplify
> the API.
Thanks, this description summarizes the situation nicely.
-Peff
Previous: Colin Hinton
Message 5 of 5 in “chdir-notify.h: Removed unused param 'name'”
  1. chdir-notify.h: Removed unused param 'name'Colin Hinton, Aug 14, 2026
  2. Jeff KingAug 14, 2026
  3. Junio C HamanoAug 14, 2026
  4. chdir-notify.h: Removed unused param 'name'Colin Hinton, Aug 14, 2026
  5. Jeff KingAug 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.