From: Jeff King <peff@peff.net>
Date: Sat, 15 Aug 2026 05:12:13 GMT
Subject: Re: [PATCH v2] chdir-notify.h: Removed unused param 'name'
Message-ID: <20260815051213.GA26013@coredump.intra.peff.net>
In-Reply-To: <20260814214210.1625-1-colinlewishinton@gmail.com>

On Fri, Aug 14, 2026 at 02:42:10PM -0700, Colin Hinton wrote:

> The `name` parameter in `chdir_notify_entry` was only ever used by
> chdir_notify_reparent() to produce trace output. That function was
> removed in 5bf546755c (chdir-notify: drop unused
> `chdir_notify_reparent()`, 2026-06-25), which left `name` with no
> remaining consumers.
> 
> Prior to that removal, most callers had already stopped passing a
> meaningful name, switching to NULL in 1f43ff2c7e (refs: unregister
> reference stores from "chdir_notify", 2026-06-25) and 0de2467e6c
> (odb/source-packed: start converting to a proper `struct odb_source`,
> 2026-06-17).
> 
> Since no caller has populated `name` with real data for some time,
> and its last consumer is gone, drop it from chdir_notify_register(),
> chdir_notify_unregister(), and the callback signature to simplify
> the API.

Thanks, this description summarizes the situation nicely.

-Peff