git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7614: avoid hiding git's exit code in a pipe

From
Shlok Kulshreshtha <diy2903@gmail.com>
Date
Jul 16, 2026, 07:12 UTC
Message-ID
<20260716071254.14953-1-diy2903@gmail.com>
In-Reply-To
<xmqq1pd4m4ea.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> All look trivially correct.
Thanks for the review.
Show 7 quoted lines
>  * This "cat-file the commit object, and strip away the object
>    header with sed" pattern appears quite often throughout the test
>    suite.
> [...]
>    or something like that.
>
> But again, these are clearly outside the scope of this patch.

Agreed on keeping them out of this patch. I'd like to take up the commit_body() helper as a separate follow-up once this lands, and convert the existing "cat-file ... | sed" call sites (including the unnecessary backslash before the dollar sign) over to it.

Thanks, Shlok

Previous: Junio C Hamano
Message 3 of 3 in “t7614: avoid hiding git's exit code in a pipe”
  1. t7614: avoid hiding git's exit code in a pipeShlok Kulshreshtha, Jul 15, 2026
  2. Junio C HamanoJul 15, 2026
  3. Shlok KulshreshthaJul 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.